Removed implicit and forced unwrapping #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project does a lot of implicit and forced unwrapping of vars. That's generally discouraged in Swift since you lose the protection of explicitly handling optionality.
Also - several vars were declared as
weak
and were also being force-unwrapped. This semantically doesn't make sense because weak vars, by definition, aren't retained and therefore must be optional. Swift should have probably always thrown an error on this - but as of Swift 5.3 in Xcode 12 Beta, force-unwrapping a weak var will no longer compile (it crashes the compiler). This PR fixes that.