Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unitaryHACK] Add type hints to _seq_drawer.py (#16) #173

Merged
merged 12 commits into from May 29, 2021

Conversation

LaurentAjdnik
Copy link
Collaborator

No description provided.

@HGSilveri
Copy link
Collaborator

@LaurentAjdnik This module has seen some changes, so there are some conflicts to resolve

@HGSilveri
Copy link
Collaborator

@LaurentAjdnik is this ready for review?

@LaurentAjdnik
Copy link
Collaborator Author

@LaurentAjdnik is this ready for review?

I guess so, if I managed to solve the merge conflicts correctly....

pulser/sequence.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a smaller one, let's try to finish it today!

pulser/_seq_drawer.py Outdated Show resolved Hide resolved
pulser/_seq_drawer.py Outdated Show resolved Hide resolved
pulser/_seq_drawer.py Outdated Show resolved Hide resolved
pulser/_seq_drawer.py Outdated Show resolved Hide resolved
pulser/_seq_drawer.py Outdated Show resolved Hide resolved
pulser/_seq_drawer.py Outdated Show resolved Hide resolved
pulser/_seq_drawer.py Outdated Show resolved Hide resolved
@LaurentAjdnik
Copy link
Collaborator Author

This is a smaller one, let's try to finish it today!

Sorry, AFK for 24 hours.

@HGSilveri
Copy link
Collaborator

This is a smaller one, let's try to finish it today!

Sorry, AFK for 24 hours.

Alright, that's ok.

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the hard work!

@HGSilveri HGSilveri merged commit 4b86dd3 into pasqal-io:develop May 29, 2021
@LaurentAjdnik LaurentAjdnik deleted the type_hints_seq_drawer branch June 2, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants