Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Add support for Python 3.12 #335

Open
awennersteen opened this issue Feb 8, 2024 · 5 comments
Open

[Enhance] Add support for Python 3.12 #335

awennersteen opened this issue Feb 8, 2024 · 5 comments
Assignees

Comments

@awennersteen
Copy link
Member

According to pytorch/pytorch#110436 PyTorch 2.2 has at least some Python 3.12 support now.

@Roland-djee
Copy link
Collaborator

We should ditch 3.9 then.

@awennersteen
Copy link
Member Author

Why? 3.9 still has 1 year, 8 months left until EOL.

Agree that if something pops up where we have to change code to build around support both we can ditch 3.9, but why would we ditch it just because?

@Roland-djee
Copy link
Collaborator

Why? 3.9 still has 1 year, 8 months left until EOL.

Agree that if something pops up where we have to change code to build around support both we can ditch 3.9, but why would we ditch it just because?

Not just because. My experience is that it is kinda painful to support more than 3 Python versions back. But it is biased because the package contained compiled code. Here, for pure Python, it might be less of a hassle.

@Roland-djee
Copy link
Collaborator

@awennersteen Torch doesn't play nicely with py3.12, right ? This is why you closed the issue on PyQ ?

@awennersteen
Copy link
Member Author

Actually it got sorted with Torch, and in PyQ it's been enabled for 3.12. With the next release of PyQ we can bump it here too

@Roland-djee Roland-djee changed the title Add support for Python 3.12 [Enhance] Add support for Python 3.12 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants