New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ping/HealthCheck endpoint needed. #113
Comments
I can take it 👋🏻
|
This (https://github.com/AppsFlyer/go-sundheit) can be used or can be implemented natively it depends how many services will be included in the future. Of course, there might be a drawback of using external library every time (-it may blow up the binary which is generated at the end.-). |
We can remove "status" lines. Just status_code and error is fine. Also I think we don't need external lib for this job. Can I assign you with this? |
Yeah, I think so as well. As I mentioned importing libraries can blow up binary, no need to import it. |
No not urgent. Anytime is fine. |
* check token earlier Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * add /health endpoint Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * add workflow to run tests Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * return NoToken Err Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * remove suffix Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com>
* Create CONTRIBUTING.md * Translation (#103) * used const and var for strings * update * update * CONTRIBUTING.md file translated into Turkish. * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING-TR.md * pre-generated issue template added (#106) Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * Removed unnecessary alpine image (#109) * Remove unnecessary alpine image * Fix mkdir command for docker Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com> * Fix libc for docker Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com> * password package implemented (#112) * password package implemented Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * app/enc/password func updated Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * rename and delete deprecated todo Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * Feature/add health check #113 (#115) * check token earlier Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * add /health endpoint Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * add workflow to run tests Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * return NoToken Err Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * remove suffix Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com> * Closes #118 * update health test * workflow db user info Co-authored-by: Recep Alaca <recep@users.noreply.github.com> Co-authored-by: Ahmet Türkmen <f.ahmet.turkmen@icloud.com> Co-authored-by: Kaan Karakaya <yusufkaan142@gmail.com>
Is your feature request related to a problem? Please describe.
We don't know if the server is running. We need a public (excluded from auth) endpoint to check server status. Then we can use uptimerobot and check the server status regularly.
Describe the solution you'd like
We need an endpoint which only returns 200 with a GET method. It should be /ping, /health or /health-check. We can search for best practice about it.
For a better health check, this endpoint can check if postgres or mysql is running and db connection is fine.
Additional context
Does anyone want to work on this?
The text was updated successfully, but these errors were encountered: