Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase code coverage by adding unit tests #116

Open
mrtrkmn opened this issue Jun 1, 2020 · 3 comments
Open

increase code coverage by adding unit tests #116

mrtrkmn opened this issue Jun 1, 2020 · 3 comments
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for this issue. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Comments

@mrtrkmn
Copy link
Contributor

mrtrkmn commented Jun 1, 2020

Is your feature request related to a problem? Please describe.

Not feature but requirement, it is clear that coverage level of the repo could be improved by increasing number of unit tests. It can provide more flexibility and easy debugging from code base without requirement of running server from scratch.

Describe the solution you'd like

  • Add more tests where possible

Describe alternatives you've considered

  • No alternative solution at the moment.
@yakuter
Copy link
Collaborator

yakuter commented Jun 3, 2020

Yes, we definitely need test which can be small for simple function or big for an endpoint behaviour. Either way, we need tests.

How do we proceed on this subject, where should we start? Do you have suggestions @mrturkmen06 ?

@yakuter yakuter added Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for this issue. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. labels Jun 3, 2020
@mrtrkmn
Copy link
Contributor Author

mrtrkmn commented Jun 3, 2020

I think, the good starting point could be AUTH and API because those are the crucial components for the project, afterwards database testing, in my opinion.

If I can find time to do that, I may, however I do not have very much time. Nevertheless, when I have spare time, I may look at it.

@yakuter
Copy link
Collaborator

yakuter commented Jun 3, 2020

No problem, this is not a one time job. I will also write test when I find time. Auth and API's are good points to start. Let's keep this issue open to remember every time.

yakuter pushed a commit that referenced this issue Jun 19, 2020
* testing sync functionality

* add tests for backup and encryption

Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com>

update GenerateSecureKey function return variables

Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com>

re-update tests

Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for this issue. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Development

No branches or pull requests

2 participants