Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an admin (on web app) I cannot add a user with a + in the email #14

Closed
BLeQuerrec opened this issue Jul 25, 2016 · 7 comments
Closed
Assignees
Labels

Comments

@BLeQuerrec
Copy link

Hi,

If I want to add a user with a plus in email (ie. bob+passbolt@example.org), I cannot validate the form (error "Only email format is allowed" is returned). Adding the user from CLI (app/Console/cake passbolt register_user ...) works fine.

Thanks.

@stripthis
Copy link
Member

Hi there,

Do you get this error as a regular user on the registration screen or are you adding the user as an admin? Thanks for the clarification!

@stripthis stripthis self-assigned this Jul 25, 2016
@BLeQuerrec
Copy link
Author

As an admin.

@stripthis stripthis changed the title Cannot add a user with a + in email from web As an admin (on web app) I cannot add a user with a + in the email Jul 25, 2016
@stripthis stripthis added the bug label Jul 25, 2016
@stripthis
Copy link
Member

Thanks @BastienLQ, I could reproduce the issue. We'll get it fixed!
Ref. PASSBOLT-1637
screen shot 2016-07-25 at 17 31 58

@stripthis
Copy link
Member

@BastienLQ this issue has been fixed for the username on the add user screen in release 1.2.0. Please note that we fix issues with '+' not being allowed elswhere like in password description and username in next release. See. issue #17. Thanks!

@silvaireboivert
Copy link

hello,

the new regex for emails does not match emails with a dot in it eg a.b@c.com

thanks,

@kevinmuller kevinmuller reopened this Oct 19, 2016
@kevinmuller
Copy link
Member

Hi @silvaireboivert ,

Indeed, a glitch got introduced in the regexp due to compatibility issues between PHP and Javascript xregexp format. We are working on a quick fix which should be available today itself.

Thanks a lot for the quick feedback!

@kevinmuller
Copy link
Member

Hi again @silvaireboivert ,

We have just released 1.2.1 to correct the issue you mentioned, and also did some cleanup in the code. See release notes

We have added a few test cases in our test suite to make sure that this bug doesn't happen again. Here is a gist showing all the emails format supported and tested in our CI process, which we we got from the CakePHP test suite. I think that it handles most of the cases, but suggestions of improvement are of course welcome if any.

Thanks again for flagging this.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants