Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL detection not working in healthcheck #27

Closed
kevinmuller opened this issue Oct 19, 2016 · 3 comments
Closed

SSL detection not working in healthcheck #27

kevinmuller opened this issue Oct 19, 2016 · 3 comments
Assignees
Labels

Comments

@kevinmuller
Copy link
Member

Issue reported by patpro on twitter:

SSL is not detected properly in healthcheck, even though the healthcheck page is accessed through HTTPS. (cf screenshot below).

screen shot 2016-10-19 at 22 09 12

Ticket reference: PASSBOLT-1721

@kevinmuller kevinmuller self-assigned this Oct 19, 2016
@p4tpr0
Copy link

p4tpr0 commented Nov 4, 2016

Just in case you have not dug into this, it's quite easy to fix.
Change file app/Controller/HealthCheckController.php to use this line:

$this->_checks['ssl'] = ($this->request->is('ssl') && configure::read('App.ssl.force'));

instead of that one:

$this->_checks['ssl'] = ($this->request->is('ssl') && configure::read('app.ssl.force'));

(app becomes App).

@stripthis
Copy link
Member

stripthis commented Nov 5, 2016

Hi @p4tpr0 yes we found out too. @kevinmuller did a fix for this on our development branch but we haven't released it yet on master. We are a bit caught up with all the exciting Chrome work :)

@stripthis
Copy link
Member

Hello @p4tpr0, this issue was fixed with release v1.3.0.
Please feel free to reopen the issue if you run into this one again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants