Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password rendering with non-monospace font makes it impossible to distinguish between "l" (lowercase L) and "I" (uppercase i) #188

Closed
nazmulkazi opened this issue Jun 20, 2023 · 6 comments
Assignees

Comments

@nazmulkazi
Copy link

Passwords are not rendered with a monospace font

  • Passbolt Version: 3.12.2
  • Platform and Target:
    -- Browser: Google Chrome version 114.0.5735.110 (Official Build) (64-bit)
    -- Ext Version: 4.0.4

Issue Description

The following is a screenshot of a password that contains both lowercase "L" and uppercase "i". As we can see, it is impossible to tell which is which.

20230620001

Expected

20230620002

All passwords (in the item's list, info sidebar, and edit form) should be rendered with monospace fonts. Visually similar letters (uppercase O and number 0; lowercase L and uppercase i and 1) should be easily distinguishable. Please use a monospace font that has a line through number 0 making it easily distinguishable when only 0 is present in a password. Thanks.

I use long randomly generated passwords everywhere. Sometimes, I need to type passwords manually on other devices where copy-pasting is not an option. It is frustrating to get the password wrong due to visually similar letters and then need to copy-paste the password to a text editor to find out what am I typing wrong.

@stripthis
Copy link
Member

Hello,

Thank you for your feedback!
This is on our radar as this is already implemented on the mobile app. Ref. PB-25251

Cheers,

@nazmulkazi
Copy link
Author

@stripthis I use the Passbolt Android app and I noticed that the app shows the password with a monospace font (though the edit form doesn't yet). So, I thought of reporting it for the Chrome extension (which I use most of the time). Thank you.

@nazmulkazi
Copy link
Author

nazmulkazi commented Jul 6, 2023

@stripthis Hi, I want to contribute to this. I have been looking through the codes. To change the font to monospace for both the webpage UI and Chrome extension, I need to make changes in the passbolt_styleguide repo, right? I already figured out where I need to add the font-family statements in the Less files. Just thought of confirming before working further on this. Thank you.

@qntoni
Copy link
Contributor

qntoni commented Jul 13, 2023

Hello,

Thanks for your interest! We made the changes and implemented the monospace font and we are currently reviewing the according code. It will come in future release.

Best regards

@nazmulkazi
Copy link
Author

That's wonderful news. Thank you so much for attending to it so promptly.

@qntoni
Copy link
Contributor

qntoni commented Jul 27, 2023

Hello @nazmulkazi,

We released Passbolt v4.1.2 that includes the monospace font while previewing a password.

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants