-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide debounced versions of some oft-updating events #63
Comments
So I pushed a
An additional note: I have added quite a lot of tests. It seems that some of them (if not all) suffer from timing issues (mostly on os x). I don't have a solution to that and adding sleeps can change the entire nature of the test (in fact there are some tests that should be split in two, one with additional sleeps and on without). As more tests are added, the chance of hitting such a timing issue increases. So it will become more and more likely that tests fail, but I would argue that the issue is with the operating system and not with notify. |
Can you think of a way to mark timing-sensitive tests as such in the output, such that it becomes easier to see whether a test run is a hard failure or may simply need a rerun to combat the timing? |
👍 on EventWithoutPath |
I think the debounce tests are more prone to timing problems but in general all tests seem to have that problem. It happens rarely, so I don't have much data (actually none, since I didn't write the failures down). So at this point I guess the best we can do is write down which tests fail how often and then look for a solution.
Any opinion on the other issues? Or the behavior of the debounce module as a whole btw.? |
Were you able to make up your mind? I think we should wrap this up and release a new version. |
I've been extremely busy at work the past two months, which has left me little motivation to work on this, and I apologise for the time it's taken to come back to it. I very much like what you've done with debouncing and everything else. I do think debounce is going to be the primary interface for most people, so it should be within notify for the best out-the-box experience. |
I re-factored the debounce code a bit and I guess it's ready for release now. Another set of eyes wouldn't hurt of cause but thanks to cargo nothing should go up in flames anyway. I had another look at the EventWithoutPath thing, but I realized that it wouldn't work as I first thought, so I didn't change it. My idea was to change the Option in RawEvent to a non-optional path, but that would only work, if it was wrapped in the Result, which it isn't. |
This has been released in 3.0.0. Looked through everything, corrected a few typos in comments and documentation, and ran it all through rustfmt 🎉 |
See #48 for reason and #60, #62 for context. In short: MODIFY events fire too often, or twice in a row, and it would be useful to only emit them once in [some time period].
The text was updated successfully, but these errors were encountered: