Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some characters not allowed in name of (host) profile #22

Closed
pro-sumer opened this issue Nov 2, 2018 · 3 comments
Closed

Some characters not allowed in name of (host) profile #22

pro-sumer opened this issue Nov 2, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pro-sumer
Copy link

As instructed in the release notes I deleted Passepartout and re-installed 1.0 (1194) from scratch. When adding my host profile for Encrypt.me I noticed that I could not use a dot in the profile name (nor a space), while this was possible before.

Is this intentional? If so, why?

(I would like to name this profile "Encrypt.me"; now it's "EncryptMe" because the dot is not allowed)

@pro-sumer pro-sumer changed the title Some characters now allowed in name of (host) profile Some characters not allowed in name of (host) profile Nov 2, 2018
@keeshux
Copy link
Member

keeshux commented Nov 2, 2018

True, and it is indeed intentional. The reason is that, starting from recent builds, the app stores configuration profiles in separate files. The profile title is used as a filename, therefore I had to get rid of potentially illegal characters for the filesystem.

That said, the dot should be harmless and I might consider re-adding it. FYI the allowed characters are currently:

let english = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
let symbols = "-_"

https://github.com/keeshux/passepartout-ios/blob/e880192be5b1dfaf085a0353164ddc42c0d73827/Passepartout/Sources/Utils.swift#L208

@keeshux keeshux added the enhancement New feature or request label Nov 2, 2018
@keeshux keeshux added this to the 1.0 milestone Nov 2, 2018
@keeshux keeshux self-assigned this Nov 2, 2018
@pro-sumer
Copy link
Author

Can I rename a profile (after that update)? How?

(Or do I need to delete the profile and add it again)

@keeshux
Copy link
Member

keeshux commented Nov 2, 2018

Wait until the next update. Renaming is a convenient feature I already wanted to add and this is a good chance to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants