Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PassFF is outdated on the "Mozilla's addons store" #207

Closed
Encrypt opened this issue Jun 26, 2017 · 16 comments
Closed

PassFF is outdated on the "Mozilla's addons store" #207

Encrypt opened this issue Jun 26, 2017 · 16 comments
Labels

Comments

@Encrypt
Copy link

Encrypt commented Jun 26, 2017

Hello PassFF devs!

I am currently PassFF that I downloaded and installed from the official "Mozilla add-ons store" here: https://addons.mozilla.org/en-US/firefox/addon/passff/

Wondering if I was the only one to encounter a few bugs, I came here and I noticed that the current version is the 1.0.0, whereas it is the 0.1.32 on Mozilla's page.

Therefore, have you planned to update the signed extension there?
If I am right, users automatically get updates for the extensions they are using when they get updated on "Mozilla's add-ons store", which is very handy 😄

Cheers!
Encrypt

@tuxor1337
Copy link
Collaborator

I answered on this two weeks ago over here: #169 (comment)

But you are right to ask. The update has been stuck in the review process for a month now. I'm also getting curious about what's going on...

@Encrypt
Copy link
Author

Encrypt commented Jun 26, 2017

Oh, great! I guess we should just wait then.

Thanks for the info, I'm looking forward to testing the updated version of PassFF! 🎉

@singron
Copy link
Contributor

singron commented Jul 16, 2017

It's worth pinging mozilla about this. It might just be lost in the queue somewhere not making any progress.

Now that addons require a mozilla signature to load at startup, there is no relief valve for AMO review slowness, so it is important that they know our pain.

The July AMO queue update showed a reduction in 10+ day long reviews, but they had recently been very high.

@Encrypt
Copy link
Author

Encrypt commented Jul 29, 2017

Hello guys! Have you had any news from Mozilla?
One month has gone by since I opened the issue and PassFF is still outdated on their extensions store 😕

As @singron said, it may be worth pinging them.

@hellomika
Copy link

hellomika commented Aug 13, 2017

https://discourse.mozilla.org/t/passff-review/18036

It seems that it's already been reviewed and rejected?

@tuxor1337
Copy link
Collaborator

Some news here: Because of issues concerning the host app under MacOS (#219, #188) and concering the general setup under Windows (#202, #171), we decided to submit a Linux-only version to AMO for now. As soon as the issues with MacOS are sorted out, a MacOS version will follow.

@tuxor1337
Copy link
Collaborator

We're in position 109 of 167 in the review queue. It definitely takes it's time. Is there anybody who would be willing to look into our macOS issues so that we can upgrade our Apple users asap? Unfortunately, I don't have access to an Apple machine for testing.

@TerminalWitchcraft
Copy link

Will the extension be compatible with Firefox web-extensions? i.e, will it support Firefox version 57+?

@tuxor1337
Copy link
Collaborator

tuxor1337 commented Aug 26, 2017

Yes: The version of PassFF currently under review on AMO will be based on WebExtensions. That's what we're all being so excited about 👍 Update: we just advanced to queue position 103 😉

@cjustin88
Copy link

cjustin88 commented Aug 27, 2017

@tuxor1337 I have a macOS machine and can help out with testing. I'm not much of a software developer though...

It is a bit of a pain to go through this approval process (but it is for good reason...I suppose?). Will future versions of PassFF require this lengthy approval or will they be expedited?

Thanks for working on this migration and AMO approval. I've freed my passwords from the grips of LastPass -- their Firefox extension is buggy and often out of date...

@tuxor1337
Copy link
Collaborator

tuxor1337 commented Aug 28, 2017

@cjustin88 Okay thanks, I will come back to you as soon as I have time to look into the macOS issue. Of course, it would be better if a developer with a macOS machine could look into this.

Regarding the approval process: In the future, approval will definitely be faster in most cases. We submitted our new version for review on May 28. Because of the major changes, it was flagged for admin review. In June, we noticed the macOS problem and told the reviewers to wait since one of our devs was hoping to fix the issue soon. However, the issue was harder than we thought and the reviewers became impatient (understandably!). So they kicked us out of the review queue at the beginning of July. Then, until the beginning of August, our AMO owner was AFK. Eventually, I was added as a new owner and I decided to submit a Linux-only version last week.

Current position in AMO queue: 99
Update (01.09.2017): Current position in AMO queue: 49

@girst
Copy link
Contributor

girst commented Sep 6, 2017

The Linux version is now available on AMO! I got the automatic update today!

Thanks to everyone involved, especially tuxor1337 and nwallace!

@Encrypt
Copy link
Author

Encrypt commented Sep 6, 2017

Yeah, same here!

However, with this new version, I can't access my passwords anymore 😕

capture

Moreover, clicking on the wheel icon (to edit the configuration) will just hide the PassFF menu.

I tried uninstalling / reinstalling the extension without success (I thought that could purge configuration files or something...). Do you have an idea?

Note: I'm running Firefox 52.3.0 on Debian Jessie.

@girst
Copy link
Contributor

girst commented Sep 6, 2017

you'll need the host application. see the README for how to install it.

https://github.com/passff/passff/blob/master/docs/INSTALLATION.md#installing-the-host-application

@Encrypt
Copy link
Author

Encrypt commented Sep 6, 2017

Indeed, I had missed that!
It works like a charm now, congratulations guys! 🎉

@tuxor1337
Copy link
Collaborator

Yes, it's now official 👍 Thanks for your patience!

@Encrypt: If your problem about the preferences button (wheel icon) persists, please open a new bug report here on Github.

I'm closing this. For users waiting for the macOS version, please refer to the blocking bugs #188 and #219.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants