Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon for passff. Not visible for many dark themes. #479

Closed
raven2cz opened this issue Jun 25, 2021 · 5 comments
Closed

New icon for passff. Not visible for many dark themes. #479

raven2cz opened this issue Jun 25, 2021 · 5 comments

Comments

@raven2cz
Copy link

raven2cz commented Jun 25, 2021

New Firefox default and dark theme design has exact color as passff icon. The icon is not visible.

In addition, the color of passff is not designed correctly, it is almost invisible in other older color schemas, like dracula themes, which is used very often.

Please consider changing the color of the icon.

For example variants:
#65b2e3
#9580ff
#ffca80
#70a99f

@tuxor1337
Copy link
Collaborator

I can't confirm this with Firefox 89:
image
We already have different icons for light/dark themes, see #253

@raven2cz
Copy link
Author

raven2cz commented Jul 1, 2021

Yes, but it is reality. It doesn't work in arch, awesomewm, qtile, xmonad etc. Maybe it is driven some property which is not set, but other icons works correctly, not pass.

In kde, gnome, it works.

image

Is there some possibility to check which property is controlled? I can provide more details, but I have to know what is important for your switch between dark and light icon.

@tuxor1337
Copy link
Collaborator

We already use the single officially supported way (https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_action#theme_icons) for light/dark themed icons:

passff/src/manifest.json

Lines 14 to 19 in e40d867

"default_icon": "skin/icon.svg",
"theme_icons": [{
"light": "skin/icon-light.svg",
"dark": "skin/icon.svg",
"size": 16
}],
I don't think that there is anything we can do on PassFF's side to fix this. This is an upstream issue.

@raven2cz
Copy link
Author

raven2cz commented Jul 2, 2021

I checked independent on windows platform, firefox 89, extension actually download from firefox store. The bug is still present, it is doesn't true that it works in firefox 89. You have to use some specific build of passff, the extension doesn't work from store.

obrazek

@tuxor1337
Copy link
Collaborator

As I said, this must be an upstream issue. Please post it on the Firefox bug tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants