Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon for passff. Not visible for many dark themes. #499

Closed
raven2cz opened this issue Nov 25, 2021 · 4 comments
Closed

New icon for passff. Not visible for many dark themes. #499

raven2cz opened this issue Nov 25, 2021 · 4 comments

Comments

@raven2cz
Copy link

I already wrote this issue and it was closed as upstream issue. Please check this issue correct way. Actual standard firefox themes cause that the icon is not visible anymore, because it has exact same color as standard theme.

passFF-icon-invisble

Your passff icon is on right side from vimium plugin. If for example vimuim plugin icon haven't these problems why your icon has it? (if it is a upstream issue?)

Please check correctly it and change the colors according these problems. Dark themes are much more used against light themes. Or add some possibility to change it by user configuration of your plugin, some switcher light/dark/auto. Thanks for help.

@tuxor1337
Copy link
Collaborator

tuxor1337 commented Nov 25, 2021

I just checked several dark themes and didn't find any for which the background color exactly agrees with the icon color. So I don't think that this is a big issue. You can solve this by adding transparency to the icon. Feel free to make a PR with this kind of change. I currently don't have time to deal with it, sorry.

@Alexey104
Copy link

Confirm (Firefox 109.0):
passff

@tuxor1337
Copy link
Collaborator

Fixed in 1.14.1

@Alexey104
Copy link

Confirm, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants