Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed users ACL #45

Open
laurivosandi opened this issue Aug 10, 2023 · 0 comments
Open

Allowed users ACL #45

laurivosandi opened this issue Aug 10, 2023 · 0 comments

Comments

@laurivosandi
Copy link
Contributor

laurivosandi commented Aug 10, 2023

Either add allowedUsers attribute to OIDCGWClient spec or include a username derived string in the groups claim (that does not collide with any existing ones). In the latter case it might be sensible to allow specifying Slack ID, Github username, Github profile ID and pretty much any attribute as the criteria.

On the other hand username would always be the local anchor so that could suffice. Maybe just including plain username in the groups claim would work? Usernames aren't allowed to contain : thus collisions should be avoided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant