Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impersonation improvements #51

Open
laurivosandi opened this issue Aug 17, 2023 · 1 comment
Open

Impersonation improvements #51

laurivosandi opened this issue Aug 17, 2023 · 1 comment

Comments

@laurivosandi
Copy link
Contributor

Applications will still retain their cookies if impersionation is triggered in OIDC gateway. This has some potential of leaking cookies/secrets across users and I guess also there is risk for real damage or data mangling.

Cleanest probably is to force administrator to start the impersionation session in incognito window
@veebkolm
Copy link
Contributor

Sounds like only way would be to create a link, which admin needs to visit to set impersonation cookie.
When visiting link, check if any cookies exist (on Passmower's host or whole domain). If exist, then deny setting impersonation cookie with an informative message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laurivosandi @veebkolm