Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has the security issue with xmldom been fixed? #1

Closed
skeddles opened this issue Jan 9, 2023 · 0 comments · Fixed by #3
Closed

has the security issue with xmldom been fixed? #1

skeddles opened this issue Jan 9, 2023 · 0 comments · Fixed by #3

Comments

@skeddles
Copy link
Contributor

skeddles commented Jan 9, 2023

I'm trying to resolve the issue mentioned here: jaredhanson/passport-twitter#107

I uninstalled the old passport-twitter module, and am now using @passport-js/passport-twitter@1.0.7

I thought this would resolve the npm audit issue, but when I ran npm audit again, it still lists xmldom as an issue, now pointing at @passport-js/xtraverse.

xmldom  *
Severity: critical
xmldom allows multiple root nodes in a DOM - https://github.com/advisories/GHSA-crh6-fp67-6883
Misinterpretation of malicious XML input - https://github.com/advisories/GHSA-5fg8-2547-mr8q
No fix available
node_modules/xmldom
  @passport-js/xtraverse  *
  Depends on vulnerable versions of xmldom
  node_modules/@passport-js/xtraverse
    @passport-js/passport-twitter  *
    Depends on vulnerable versions of @passport-js/xtraverse
    node_modules/@passport-js/passport-twitter

Is this a false positive or has it yet to be fixed?

Could anyone clear this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant