Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information that rules can be customized #3

Closed
szotp opened this issue Oct 3, 2019 · 2 comments
Closed

Add information that rules can be customized #3

szotp opened this issue Oct 3, 2019 · 2 comments

Comments

@szotp
Copy link

szotp commented Oct 3, 2019

Thanks for making this package.

I think it would make sense to inform people that these rules can easily be customized. It was not clear to me until I checked Dart docs.

Ignoring rules is very nice when migrating from ugly codebase - I just added this to my project and I have hundreds of warnings and errors. I fixed what I could, ignored the rest, and will continue cleanup when I have more time.

@passsy passsy closed this as completed in 0214fd5 Oct 4, 2019
@passsy
Copy link
Owner

passsy commented Oct 4, 2019

Good point, added!

@kuhnroyal
Copy link

kuhnroyal commented Jan 7, 2020

This is not working correctly for me, I don't think this is an issue of this library but maybe you know where to look. My guess is somewhere in the analyzer.

lint version: 1.1.0
analyzer version: 0.38.5

This works: extending the set of rules with the YAML list syntax

include: package:lint/analysis_options.yaml

linter:
  rules:
    - prefer_double_quotes

This does not work: extending the set of rules with the YAML property syntax

include: package:lint/analysis_options.yaml

linter:
  rules:
    prefer_double_quotes: true

Now only prefer_double_quotes gets flagged as warning.
As a result one can not remove a rule that is configured in the lint package. Only adding is possible.

This could also be a limitation or bug in some YAML library that prevents the merging of List and Map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants