Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install instructions should specify to put package in dev_dependencies and not dependencies #45

Closed
guyluz11 opened this issue Nov 10, 2021 · 4 comments

Comments

@guyluz11
Copy link

In the pub.dev install section of this package it is written to insert the dependency under dependencies.
As this dependency is not running while the software is running (as far as I know) it should be placed under dev_dependencies.

image

Is it ok to place it under dev_dependencies and if it does can we change it in the pub.dev install page for the incoming users?

@passsy
Copy link
Owner

passsy commented Nov 10, 2021

Unfortunately there is no way to tell pub.dev what to show on the install site dart-lang/pub-dev#2125

package:test is explicitly whitelisted

@guyluz11
Copy link
Author

Weird
So what about this one for example?
image

@passsy
Copy link
Owner

passsy commented Nov 11, 2021

There is now an allow-list of special dev packages. We could create a PR, but I'm not sure if 3rd party packages will be added.

Let's see dart-lang/pub-dev#5258

@passsy
Copy link
Owner

passsy commented Nov 11, 2021

Got merged :)
--dev should be show up in the coming days. Thanks for bringing it up :)

@passsy passsy closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants