Enabled skip-parent functionality to allow navigation to root fix #75 #108
Conversation
…e root directory.
apacha
changed the title
|
Hey! I just noticed that you updated this recently. Do you still want to merge this? I'd be happy to if we can fix the merge conflict. :) |
|
Feel free to merge it... apparently the last commit was not intended to be part of this PR, but I forgot that it was open... If you want, you can also reject this PR and just commit the two lines, that I've changed in 953f460 |
|
Ok, I've just reset my repo, so the PR is clean again now. |
|
any update on this PR merge? thanks! |
|
Maintainer seems to have forgotten this PR |
|
@apacha I suggest to take a look at https://github.com/spacecowboy/NoNonsense-FilePicker I switched to this library recently and it works flawlessly. I tried using this one with your fix and jitpack.io automatic maven repository, but it doesn't build (not for your fix but for other reasons) |
|
Hi, apologies for the long delay. GitHub notifications have mostly lost all use for me and sadly this commit doesn't follow the commit guidelines linked above, so I can't merge this without editing it manually myself. I'll try to look into it tomorrow, but if you could do it yourself, that would be of great help. :) |
|
Honestly, no.
Either accept it or change the one line and commit on your side without
this PR.
I've lost interest in this a long time ago.
On 22 Apr 2018 22:23, "Pascal Hartig" <notifications@github.com> wrote:
Hi, apologies for the long delay. GitHub notifications have mostly lost all
use for me and sadly this commit doesn't follow the commit guidelines
linked above, so I can't merge this without editing it manually myself.
I'll try to look into it tomorrow, but if you could do it yourself, that
would be of great help. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAkSQdw3210Fsgu6AFC0gKqaXu69rQBOks5trOangaJpZM4L-cEM>
.
|
|
Fair enough. Sorry for the trouble. |
|
@passy - what was missing from the commit guidelines? Was it the commit message, or lack of tests or something else? If you let me know I can look into resubmitting this to follow guidelines, as this is a feature I'd really like |
|
Hey Parker! That would be great! There are a few guidelines for the commit
messages that allow them to he automatically parsed into a changeling,
making the release process significantly easier. You can read the linked
doc or check out the repo history for some examples.
If you would like to improve the test coverage too, that would be fantastic.
On Tue, 15 May 2018, 18:00 Parker Kuivila, ***@***.***> wrote:
@passy <https://github.com/passy> - what was missing from the commit
guidelines? Was it the commit message, or lack of tests or something else?
If you let me know I can look into resubmitting this to follow guidelines,
as this is a feature I'd really like
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAmsr70ASYhzfvSecFkNiiU2SS1e2idks5tywmzgaJpZM4L-cEM>
.
--
timezone: eu/london | utc+1
@passy
|
|
Hi guys, i still don't understand how to get a root directory. Do you find any "step by step" decision? |
Contributor checklist
Description
It's a rough draft to overcome limitations that one can no longer navigate higher than the root-path of the internal SD-card on current Android-Versions (>4.4, on some devices >5) as described in #75. By skipping a parent directory, that one has no access to, this functionality is restored.