Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force pastastore name to equal pandas object name #19

Closed
dbrakenhoff opened this issue Jul 17, 2020 · 2 comments
Closed

Force pastastore name to equal pandas object name #19

dbrakenhoff opened this issue Jul 17, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dbrakenhoff
Copy link
Member

Problems arise when the name of the added pandas series (or name of the column in the case of DataFrames) does not match the name that is used in the store.

This discrepancy in names can cause weird stuff to happen when pastas StressModels are created directly from pandas objects (after being retrieved from the store). The name of the series in the model then differs from the name of the series in the pastastore. Since models and timeseries are stored separately, the name of the timeseries in the model cannot be matched to objects in the store, which causes problems.

The proposed solution is to force the name of the pandas series to match the name in the pastastore. Also removing support for multi-column DataFrames should simplify enforcing this requirement.

@dbrakenhoff
Copy link
Member Author

Implemented through d0b960d

@dbrakenhoff dbrakenhoff self-assigned this Jul 17, 2020
@dbrakenhoff dbrakenhoff added the enhancement New feature or request label Jul 17, 2020
@dbrakenhoff
Copy link
Member Author

Closed by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant