Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework status effect integration #32

Open
guerro323 opened this issue Jun 27, 2021 · 0 comments
Open

Rework status effect integration #32

guerro323 opened this issue Jun 27, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@guerro323
Copy link
Collaborator

As for now, status effects must have the same variables as the base component, which restrict in how some status effects could work.
The problem is that it make stuff much more complicated to work with and to replicate onto the Unity client. (a status effect is an inherited component, but it's working weirdly)

Proposed solutions:

  • Keep the way it work, but simplify the component itself (the variable Type shouldn't be in the component since we can already tell the type from the component itself).
  • Convert all status effects into a buffer. This may make it a bit more complex to work with, but it's easier to replicate it. Mods that require a different way to work with its own status effect could just implement a new buffer.
  • Convert status effects into a big component. While easier to work with and replicate it, it's a problem if an entity shouldn't have that status effect. For mods it would work as the previous point.
  • Make a mix of 1 and 2. Status effects components can have a freedom of variables, but there would be a buffer that contains the read-only state.

If I go for the last and first point, the way inherited component work should be remade

@guerro323 guerro323 added the enhancement New feature or request label Jun 27, 2021
@guerro323 guerro323 self-assigned this Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant