Refine Share

[penrods]

The basic Share functionality works, but it could use some refinement. Specfically two things:

• Improve the filename. Currently it is ".null". Change it to be "PrivateKit_.json"
• Add a message body. Try:
  Here is my location log from Private Kit.
• If titles are supported, make it: "Shared PrivateKit_.json"

[tushar-dadlani]

.null is on android on iOS it shows up as (null)-someid.data

improved the filename for android, need someone to test, for iOS - will need to do something like https://github.com/react-native-community/react-native-share#share-remote-pdf-file-with-gmail--whatsapp-ios

I have made some changes here: https://github.com/tushar-dadlani/private-kit/tree/tdadlani/fix_share_name

would love your thoughts before I open a PR

[tremblerz]

Looks good based on changes, haven't tested it yet. Can you open a PR @tushar-dadlani ?

[tushar-dadlani]

I am breaking this into 3 parts

1. Save file to disk with the correct name
2. Share the file from filesystem
3. delete the file locally

[tremblerz]

I would recommend avoiding that route if possible because other Apps can pickup for the time it is on disk (making the data non-private in a sense). At the same time I am aware of this issue being the library issue not ours so take your call.

[tremblerz]

Export on iOS is still an issue when sent as an attachment on Apps like gmail and whatsapp

[tremblerz]

Fixed in #283