Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaced attributes do not update #124

Open
AndyOGo opened this issue Apr 18, 2018 · 3 comments
Open

Namespaced attributes do not update #124

AndyOGo opened this issue Apr 18, 2018 · 3 comments

Comments

@AndyOGo
Copy link

AndyOGo commented Apr 18, 2018

Using SVG sprites with <use xlink:href="" /> will not update the icon.

The reason is that getAttributeNS and setAttributeNS DOM APIs are inconsistent in it's arguments.
E.g.: lets say 'foo:bar' ('foo' being the namespace and 'bar' the local attribute name):

Affected Code
https://github.com/patrick-steele-idem/morphdom/blob/master/src/morphAttrs.js#L19-L23

@AndyOGo
Copy link
Author

AndyOGo commented Apr 18, 2018

same issue for nanomorph choojs/nanomorph#101

@AndyOGo
Copy link
Author

AndyOGo commented Apr 18, 2018

Issue originally found in axa-ch-webhub-cloud/pattern-library#411

@AutoSponge
Copy link
Collaborator

SVG2 has fairly wide support now and IE11 is end-of-life. It may not be worth changing the code but encouraging folks to remove xlink:href.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants