Added ngx-lite-video in entities #206
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
oh, sorry tests need fixing.
this also impacts LH so would prefer a quick LGTM from @adamraine or @paulirish
|
lgtm! |
lib/__snapshots__/index.test.js.snap
Outdated
| "Google Fonts - https://fonts.gstatic.com/stats/Ubuntu/normal/700", | ||
| "Other Google APIs/SDKs - https://www.google.com/xjs/_/js/md=1/k=xjs.qs.en_US.lV9-yIzYVQw.O/ck=xjs.qs.6H7if2Wkqlc.L.W.O/ct=zgms/am=ggAKAACARRj50xlGOaI4gH8JYMYBAAAm4DDB_gKoEE8ACIAAhK2EBA/rs=ACT90oHTsQ6_NdRrrQpQMC5y1T_UyuurBw", | ||
| "Google/Doubleclick Ads - https://stats.g.doubleclick.net/robots.txt", | ||
| "Google Fonts - https://fonts.gstatic.com/stats/Ubuntu/normal/700 |
There was a problem hiding this comment.
I'm not sure what happened here, but tests are failing because of all of these added newlines. diff should just be adding your great new facade :)
There was a problem hiding this comment.
I restored the file to it's original state since I don't have new urls
There was a problem hiding this comment.
So sorry for this mistake 😅
|
🎉 This PR is included in version 0.23.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi Patrick, I was wondering how to make my facade appear in lighthouse recommendations (https://developer.chrome.com/en/docs/lighthouse/performance/third-party-facades/), I already added it to entities.js but still it did not show up I was hoping if you can help me know how to add it there 😅 |
|
@patrickhulce thank you so much |
No description provided.