Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable (list) for additional command line arguments/flags passed to promtail #167

Closed
life5ign opened this issue Mar 27, 2023 · 1 comment · Fixed by #207
Closed
Labels
enhancement New feature or request

Comments

@life5ign
Copy link
Contributor

e.g., I'd like to use "-print-config-stderr", plus a few others, but can't with this role; this variable can be a list, and if it's defined, they can be looped over when templating the systemd unit file.

The variable could be "promtail_additional_arguments" or "promtail_additional_runtime_flags" and default to []

I consider this a very important feature, so the user isn't limited by what is defined in the role. Thanks, great role!

@patrickjahns patrickjahns added the enhancement New feature or request label Apr 4, 2023
@patrickjahns
Copy link
Owner

This sounds like a very useful feature - I'd be happy to accept a pull request for this.

I would not be using this feature myself - so extending one of the test-cases would probably be good, so we can catch if there are any regressions with that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants