Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtail_config_expand_env variable is wrong by default #187

Closed
azhinu opened this issue Sep 1, 2023 · 1 comment · Fixed by #194
Closed

promtail_config_expand_env variable is wrong by default #187

azhinu opened this issue Sep 1, 2023 · 1 comment · Fixed by #194
Labels
bug Something isn't working

Comments

@azhinu
Copy link
Contributor

azhinu commented Sep 1, 2023

In defaults/main.yml variable promtail_config_expand_env have a string type. And condition in templates/service.j2 have no bool filter. As result with the default vars option -config.expand-env will be true. When promtail_config_expand_env is false without quotes, option -config.expand-env will be false.

Also templating -config.expand-env={{ "true" if promtail_config_expand_env else "false" }} can be simplified to -config.expand-env={{ promtail_config_expand_env | string }}

@patrickjahns patrickjahns added the bug Something isn't working label Sep 6, 2023
@patrickjahns
Copy link
Owner

Thank you for reporting this - if you send a pull request, I'd be happy to release a fixed version with your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants