Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

".js" in generator (jspm branch) #19

Closed
anorudes opened this issue Jul 4, 2015 · 1 comment
Closed

".js" in generator (jspm branch) #19

anorudes opened this issue Jul 4, 2015 · 1 comment

Comments

@anorudes
Copy link

anorudes commented Jul 4, 2015

Master branch:
https://github.com/angular-class/NG6-starter/blob/master/generator/component/temp.component.js
jspm branch:
https://github.com/angular-class/NG6-starter/blob/jspm/generator/component/temp.component.js

We must remove the ".js", becouse import does not see it

@danthareja
Copy link
Contributor

Good call. The reason the extra ".js" extension slipped in here is SystemJS spec (the module loader that JSPM is built on top of) actually expects these extensions to exist by default.

There is a defaultJSExtensions setting included that JSPM takes advantage of for now making the extra extension not necessary, but in the near future we might expect to see the '.js' being required.

danthareja added a commit to danthareja/NG6-starter that referenced this issue Jul 4, 2015
danthareja added a commit that referenced this issue Jul 4, 2015
fix(generator): remove js extensions. closes #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants