-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e tests not run with PhantomJS #55
Comments
is this needed after you made your PR? if it's still needed can you make another PR? |
After #79 has been merged this issue should be fixed. For me |
awesome thanks! |
Sorry @gdi2290, I think you have to reopen this issue. I have had Chrome in my setup, not phantomjs. The latter indeed makes problems. Unfortunately I have no quick solution, so we have to start over. |
@dotcs what promles makes PhantomJS Unit tests run? |
Using the "recommended" config below, I could get the first E2E test to work (which checks the title of the page), but the following tests fail because it seems that PhantomJS does not wait for Angular before running the tests which is why they fail with an
The linked document absolve also states:
So perhaps we should not use PhantomJS at all for E2E tests. [1]: Some details on the
|
If the issue is still valid please open a PR |
Workflow:
Console only show, tests does not run
I modifyed protractor.conf.js
The text was updated successfully, but these errors were encountered: