Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure container height larger than items #248

Closed
CupOfTea696 opened this issue Jun 29, 2016 · 12 comments
Closed

Ensure container height larger than items #248

CupOfTea696 opened this issue Jun 29, 2016 · 12 comments
Labels

Comments

@CupOfTea696
Copy link

When hiding / showing items it happens sometimes that the container's height changes faster than the items' opacities. This causes items to get "cut off" at the bottom. I removed the fade effect to make this issue more visible.

I'm using a flexbox layout.

My Configuration:

{
    animation: {
        effects: 'stagger(50ms) scale(0.5)',
        duration: 40000,
        easing: 'ease',
        perspectiveOrigin: '50% 0',
        animateChangeLayout: true,
        animateResizeTargets: true
    },
    controls: {
        enable: false
    },
    layout: {
        display: 'block',
        containerClassFail: 'empty'
    },
    selectors: {
        target: '.feed-item'
    }
}

screen shot 2016-06-29 at 11 21 12

@patrickkunka
Copy link
Owner

The best solution to this problem is to apply a min-height to your container to ensure that elements are never "cut off"

@CupOfTea696
Copy link
Author

I can't really do that, this page has dynamic content. This would cause the page to on occasions have a way larger height than necessary, and on other occasions the min-height might not be enough and I'd still have this issue. I hope you can consider reopening this issue.

@patrickkunka
Copy link
Owner

Thanks for the additional information - that's very useful. Does your project require overflow: hidden; on your container?

@patrickkunka patrickkunka reopened this Dec 14, 2016
@CupOfTea696
Copy link
Author

It does, yeah.

@patrickkunka
Copy link
Owner

Would you mind sending me a link to the page (if its live)?

@CupOfTea696
Copy link
Author

Unfortunately I can't, this was client work for a campaign site, and the campaign has ended so we took the site down.

@tsawitzki
Copy link

@CupOfTea696 Would be curious to find out what you did to overcome the problem …?

@CupOfTea696
Copy link
Author

@tsawitzki I don't have a solution. The site went live with the bug.

@Kwapi
Copy link

Kwapi commented Oct 10, 2017

I might have a similar issue. When I change the page on my news section the whole mixitup container seems to disappear for a split second. I tried adding min-height to both the mixitup container and the parent div but nothing works.

Here's the video of the issue:
Google drive link

@tsawitzki
Copy link

@Kwapi can you give some information on how you specified the min-height? Did you use % or vh units? Maybe in case of % there is no relation as to what the min-height refers to?
Maybe you need to wrap something around the whole mixitup container and specify the min-height there? In your video even the whole footer moves up, so I was thinking there is some issue with the general html/css architecture maybe?

@patrickkunka
Copy link
Owner

patrickkunka commented Oct 11, 2017

Hi @Kwapi - this isn't related to the issue above, but is more likely a markup structure issue. Would you be able to share a link to your project? (also if you could open a new issue for it that would be great). Thanks.

@Kwapi
Copy link

Kwapi commented Oct 11, 2017

@tsawitzki @patrickkunka
I answered your questions and moved the issue to here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants