-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with the browser, tries to require fs
#2
Comments
Mmmm, there is a browser version: https://cdnjs.com/libraries/babel-core Just need to look how to set it up to use that an include in in the target for browser and publish a hybrid package |
I'm not sure how you'd both use |
Ah, this happens when using esm in the browser. So publish a second version which is only for browser... |
it should also work if you add |
fixed in c43fa55. import { } from 'ember-template-tag/browser-esm'; |
The browser version also uses babel core and is built with webpack... It has a lower size than including standalone |
I gave this another go -- but was unsuccessful -- was the above change released? https://www.npmjs.com/package/ember-template-tag?activeTab=code |
it should also work if you add |
Yeah, forgot to build it... But with fs: false the size is smaller as the browser build includes glimmer as well. |
the non-@babel/standalone dependencies, in particular
@babel/core
, attempts to loadfs
, which doesn't exist in the browser.The text was updated successfully, but these errors were encountered: