Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CacheGetManyConcurrent tests has incorrect key #111

Closed
Gobd opened this issue Sep 30, 2019 · 1 comment
Closed

CacheGetManyConcurrent tests has incorrect key #111

Gobd opened this issue Sep 30, 2019 · 1 comment

Comments

@Gobd
Copy link

Gobd commented Sep 30, 2019

I think these two lines should be k := "foo" + strconv.Itoa(i) (i instead of n) so that each key is different. This will make the sharded cache look better since keys will be able to spread out.

@patrickmn
Copy link
Owner

Yep, you're right. What a weird mistake -- thanks for noticing it. Will fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants