Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

starterkit-mustache-demo are always fetch on init #7

Closed
raphaelokon opened this issue Nov 16, 2016 · 5 comments
Closed

starterkit-mustache-demo are always fetch on init #7

raphaelokon opened this issue Nov 16, 2016 · 5 comments
Assignees
Labels

Comments

@raphaelokon
Copy link
Contributor

Add a check if starter kits are already present in node_modules

@raphaelokon raphaelokon added this to the 0.0.1 milestone Nov 16, 2016
@raphaelokon raphaelokon self-assigned this Nov 16, 2016
@raphaelokon
Copy link
Contributor Author

@bmuenzenmeyer This one fails because require('starterkit-mustache-demo') cannot find starterkit-mustache-demo as a module. We had the same problem with edition-node – because those modules likely do not have an entry point, in which case require doesn't recognize the module being already present in node_modules

@bmuenzenmeyer
Copy link
Member

confirmed - https://github.com/pattern-lab/starterkit-mustache-demo/blob/master/package.json

on it

@bmuenzenmeyer
Copy link
Member

@raphaelokon please retest.

note every starterkit will need this same fix applied to it

@raphaelokon
Copy link
Contributor Author

Cheers. Will do!

@raphaelokon
Copy link
Contributor Author

This saved it … we probably need a better check in future but it is good to go for now. Thanks @bmuenzenmeyer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

No branches or pull requests

2 participants