Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu doesn't close when clicking item #60

Open
ctron opened this issue Jun 22, 2023 · 0 comments
Open

Dropdown menu doesn't close when clicking item #60

ctron opened this issue Jun 22, 2023 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@ctron
Copy link
Member

ctron commented Jun 22, 2023 •
edited

When clicking on the item of a dropdown menu the expectation is that the menu closes again. Currently it doesn't.

This is a regression coming from the PF5/Menu migration.

I think the proper solution is to:

  • Introduce a new MenuContext
  • Have some root-level/menu controlling component inject it
  • Giving any child component the ability to "request close" the menu
@ctron ctron added the help wanted Extra attention is needed label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctron