Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success state of input field #119

Closed
gdoyle1 opened this issue Nov 25, 2019 · 5 comments
Closed

Success state of input field #119

gdoyle1 opened this issue Nov 25, 2019 · 5 comments
Assignees
@maryshak1996
Labels
on hold Holding work until the component is developed symbol New addition or edit to symbol library
Projects
PatternFly design kit

Comments

@gdoyle1
Copy link
Contributor

gdoyle1 commented Nov 25, 2019 •
edited

Create a variation of the input field that includes success styling. patternfly/patternfly#2320

Will tag you @maryshak1996 once the color palette has been updated!
@gdoyle1 gdoyle1 added the symbol New addition or edit to symbol library label Nov 25, 2019
@gdoyle1 gdoyle1 added this to Backlog in PatternFly design kit Nov 25, 2019
@gdoyle1 gdoyle1 moved this from Backlog to In progress in PatternFly design kit Nov 26, 2019
@gdoyle1 gdoyle1 added the on hold Holding work until the component is developed label Nov 26, 2019
@maryshak1996
Copy link
Contributor

maryshak1996 commented Dec 2, 2019 •
edited

@gdoyle1
Not sure what the best way to share this is but here's a sketch cloud link that has the new symbol. Note: to be consistent with how the danger state works, I created an appearance for the green underline
The naming structure of everything (the symbol itself, the padding group, the success underline appearance, etc.) should all be consistent with the structure used in the library. so in theory you could be able to just copy-paste the symbol into the master file's symbol page!
https://sketch.cloud/s/bZaVj

@maryshak1996
Copy link
Contributor

image
^ preview

@gdoyle1
Copy link
Contributor Author

gdoyle1 commented Dec 3, 2019

That's great! Thanks @maryshak1996 - in the future, you can also zip the sketch file in your comment but sketch cloud works as well!

@gdoyle1
Copy link
Contributor Author

gdoyle1 commented Dec 6, 2019

@maryshak1996 Just requested access for that sketch file

@gdoyle1 gdoyle1 moved this from In progress to In review in PatternFly design kit Dec 6, 2019
@gdoyle1
Copy link
Contributor Author

gdoyle1 commented Dec 10, 2019

Merged!

@gdoyle1 gdoyle1 closed this as completed Dec 10, 2019
@gdoyle1 gdoyle1 moved this from In review to Done in PatternFly design kit Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryshak1996 maryshak1996

Labels
on hold Holding work until the component is developed symbol New addition or edit to symbol library
Projects
PatternFly design kit
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maryshak1996 @gdoyle1