Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radios with more information #135

Closed
katierik opened this issue Sep 26, 2019 · 14 comments
Closed

Radios with more information #135

katierik opened this issue Sep 26, 2019 · 14 comments
Assignees
Labels
template New page layout or edit to template file

Comments

@katierik
Copy link

There are use cases to show additional descriptive information with a radio button.

Screen Shot 2019-09-26 at 11 10 35 AM

It is likely that this would also be helpful as an option for checkboxes, but I do not have use cases for this as of writing.

Notes/screenshots:
https://docs.google.com/document/d/13NkTdfpH7ZD7gBsmhYgjlux9K2mKa5s9t5JNmFV_KpI/edit?usp=sharing

–––––––––––––––––––––––––––––––––––––––––––––––––––––––––––

Final Designs:
marvel: https://marvelapp.com/50eh328/screen/64407412
raw file: https://sketch.cloud/s/l8Dk4

@mcarrano
Copy link
Member

mcarrano commented Oct 4, 2019

@mcoker can you take a look at this? Is there a way to create this using existing components or do we need to create a custom radio or check component that includes a block of descriptive text?

@mcoker
Copy link

mcoker commented Oct 4, 2019

@mcarrano currently you can build something similar using the content component's <small> element, which is used for "side comments, such as small print." You can read more about that here - https://www.w3.org/TR/2011/WD-html5-author-20110809/the-small-element.html

And here is a demo - https://codepen.io/mcoker/pen/yLLLYor

As for whether we want to build something to support this layout with radios/checks, we could build support for this in the radio and check components themselves, or this could be some sort of description text associated with a Form component's Form Group, and used with any sort of form group in a form.

@lboehling
Copy link

lboehling commented Dec 5, 2019

Hi all!
Here are my design proposals for solving the use cases listed in @katierik requirement docs.
https://marvelapp.com/50eh328/screen/64407412 (first page has all three use cases, next page has spacing/specs called out)

raw file: https://sketch.cloud/s/l8Dk4

@mcarrano I know there have been previous requests for tiles and their hover/selected states. I included design proposals in the mock above. Do you think this should be a separate component/issue?

cc: @mcoker @mcarrano

@mcarrano
Copy link
Member

mcarrano commented Dec 5, 2019

@lboehling these designs looks great. @mcoker do you see any issues? Also, how would we implement this? Do you see it as part of the radio and check components or some separate element that is added to the form?

Regarding the hover/select states for cards, there is another issue open for that here: patternfly/patternfly#2470 Can you add those mocks to this issue? Thanks.

@mcoker
Copy link

mcoker commented Dec 5, 2019

The stacked descriptions look like something that would be built into the radio component itself. The description would be placed in the layout underneath the radio label.

The horizontal descriptions are a bit different. It seems like there is an overall layout (in the designs) that these radio components are a part of, and the radio/label/description are positioned by that layout. In that case, the description would not be a part of the radio component itself, and instead text that is adjacent to a radio element. In Josh's mockup, the description in the horizontal/tabular radios is black. If we can use black text, I think that's as simple as using a radio in a table, and simply putting the description in the adjacent cell (as normal text). Would that be acceptable? If not, the radio descriptions in @lboehling's design looks like it would be "helper text" in a horizontal form layout.

As a side note, would we also add this for the check component? They have the same layout currently.

@lboehling
Copy link

I think this would be good to add to both checkbox and radio components.

@mcarrano
Copy link
Member

mcarrano commented Dec 6, 2019

I agree @mcoker The radio buttons with horizontal descriptions can be achieved with a layout the includes radios (or checkboxes) and text in a two column table. Therefore, I think that I would limit this issue to provide the vertically stacked description as part of the component. That was what I saw as the original ask. Does that make sense?

@mcoker
Copy link

mcoker commented Dec 6, 2019

@mcarrano sounds good to me!

@mcarrano
Copy link
Member

@mcoker @lboehling can we consider this done? I revisited the designs and it seems like the first solution, Radios with stacked descriptions, addresses this issue. If you feel like you have everything you need, @mcoker , then I can open a new issue for core implementation and add to the prioritized backlog.

@mcoker
Copy link

mcoker commented Dec 16, 2019

@mcarrano Yep, go ahead and open an issue. Thanks @mcarrano and @lboehling

@mcarrano
Copy link
Member

I've opened a new core issue here: patternfly/patternfly#2526

@lboehling can you just upload your original artwork to Sketch Cloud and add a link for future reference? Thanks.

@lboehling
Copy link

@mcarrano added to the first comment in this issue!

@mcarrano
Copy link
Member

Thanks @lboehling . Will close this one out.

@mcarrano mcarrano transferred this issue from patternfly/patternfly Dec 20, 2019
@gdoyle1 gdoyle1 added the template New page layout or edit to template file label Jan 6, 2020
@gdoyle1 gdoyle1 added this to Backlog in PatternFly design kit Jan 6, 2020
@gdoyle1 gdoyle1 self-assigned this Jan 14, 2020
@gdoyle1 gdoyle1 moved this from Backlog to In progress in PatternFly design kit Jan 14, 2020
@gdoyle1
Copy link
Contributor

gdoyle1 commented Jan 27, 2020

Merged in symbol library!

@gdoyle1 gdoyle1 closed this as completed Jan 27, 2020
@gdoyle1 gdoyle1 moved this from In progress to Done in PatternFly design kit Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template New page layout or edit to template file
Development

No branches or pull requests

5 participants