New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Optional Header in Wizard Component #2191
Comments
@mcarrano what do you think? From slack, Matthew also said:
|
@mmocniak-rh @mcoker Are we saying that the header may appear or disappear per each step? I'd be concerned about the position of the steps bar jumping if the header is hidden. Is there a reason you'd want to hide the header other than avoiding redundancy? |
@mcarrano I'd expect the header to either be visible or hidden for the entire wizard, depending on which version is used. Maybe I am missing something from the provided examples in PF4 documentation, but I am looking for a title that is more dynamic than the same, static title across all steps. Making the header optional also cuts down on the required vertical space. If the same effect of a title with content can be achieved in the main section of a wizard without a header, then a "condensed" version of the wizard may be ideal. |
We could improve the doc a bit. Here is my interpretation and suggestions when I look at https://www.patternfly.org/v4/design-guidelines/usage-and-behavior/wizard#simple-wizard
|
@mmocniak-rh I feel like the Wizard title is important for the reasons @jeperry stated. It reinforces that intended outcome of the wizard. I agree that our design guidelines could be better and we should clarify what these fields are used for and how to reflect the current step as @jeperry suggests. I don't want to make the header optional, but I do have one question for you @mcoker . Description is optional, I believe. If a consumer of this chooses not to add a description, is the space collapsed or does that space just remain blank? If the later, we might want to make a change to reduce the space that the header consumes. Thoughts? |
@mcarrano since it's optional, we balance out the layout when the description isn't present. |
That's great @mcoker . |
@mmocniak-rh thanks for submitting this, but after discussion with @mcoker and @kybaker we have determined that the Wizard header should not be optional and this issue will be closed. It is important that the Wizard always have a title to identify the action that they will take. Being able to hide the description as shown above helps compress the space required. Also note that the height and width of the wizard modal can be adjusted if you need to create more space for content. A related documentation issue has been created to provide better guidance about this (patternfly/patternfly-org#1454). |
Some workflows do not require the header to display on every step of the wizard. Since each step dynamically changes what displays in the primary section of the wizard, the header does not always need to be present.
This issue is being logged to make allow for an option to disable the header in the wizard component.
The text was updated successfully, but these errors were encountered: