Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch enhancement: visual differentiation for on/off states #914

Closed
jgiardino opened this issue Nov 8, 2018 · 5 comments
Closed

Switch enhancement: visual differentiation for on/off states #914

jgiardino opened this issue Nov 8, 2018 · 5 comments
Assignees
Milestone

Comments

@jgiardino
Copy link
Contributor

Currently, the visual styling of the on/off states of the switch could make it difficult for some users to differentiate the two states.

image

Some ideas of how to address this issue:

  1. include some additional indicator that means “on” (similar to Carbon, Salesforce, Ant)
  2. use more of an opposite background color for "off"
  3. display a tooltip on hover
@mceledonia
Copy link

Visual proposal for new switches:

image

Spec:

On
10px checkmark icon, white, 8px spacer from the left

Off
Background color to #BBBBBB

Disabled
Background color to #8B8D8F
Switch nob color to #D1D1D1

FYI @kybaker

@jgiardino
Copy link
Contributor Author

Thanks for turning this around so fast!

For the disabled version in the on state, should we also include the checkmark in that one, too?

@mcarrano
Copy link
Member

Including the checkmark in both active and disabled states definitely makes sense. @mceledonia can you make that update and we can move this along?

@mcarrano mcarrano added css and removed visuals labels Nov 26, 2018
@mcarrano mcarrano moved this from Visual Design to CSS/HTML Development in PatternFly 4 Feature Board Nov 26, 2018
@jameslau jameslau self-assigned this Jan 3, 2019
@jameslau
Copy link
Member

jameslau commented Jan 4, 2019

Hey folks,

I've been tasked to make initial changes for the switch states. @mceledonia, there are several weights (see below) for the check mark from Font Awesome that can be applied to our switch component. Unfortunately, the first one is the only free version. The other weights require a Font Awesome Pro account. @mcoker, do you know if our Font Awesome account/version is standard or pro edition?

Checkmark examples:
https://fontawesome.com/icons/check?style=solid
https://fontawesome.com/icons/check?style=regular
https://fontawesome.com/icons/check?style=light

@jameslau
Copy link
Member

jameslau commented Jan 4, 2019

Thanks @mcoker for verifying the Font Awesome version that we have. @mceledonia, can we only use the first icon. I have it semi working now. I will need to adjust the size and color to match the comps you provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants