fix(popover): scope title class to popover component #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pf-next ready! Built with commit a4f0e2a |
christiemolloy
requested changes
May 24, 2019
| @@ -76,6 +76,11 @@ | |||
| padding: var(--pf-c-popover__content--PaddingTop) var(--pf-c-popover__content--PaddingRight) var(--pf-c-popover__content--PaddingBottom) var(--pf-c-popover__content--PaddingLeft); | |||
| background-color: var(--pf-c-popover__content--BackgroundColor); | |||
|
|
|||
| > .pf-c-title { | |||
| margin-bottom: var(--pf-c-popover--c-title--MarginBottom); | |||
| line-height: 1; | |||
There was a problem hiding this comment.
When I inspect this, it looks like the line-height from the title component (1.5) is overriding the line-height (1) that is set here. Do you see that too?
There was a problem hiding this comment.
Ah nice catch, I don't know why line-height: 1 is there. If the title wraps to 2 lines, there isn't enough space/leading. I'm going to remove that :)
|
🎉 This PR is included in version 2.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1856