fix(modal): add left aligned footer buttons variation #2182
Conversation
|
PatternFly-Next preview: https://patternfly-next-pr-2182.surge.sh |
There was a problem hiding this comment.
@mcoker I see that you've moved the buttons to the left, but the order also needs to change. The submit (Save) button should come first, i.e. Save, Cancel.
Also something seems to be messed up with the examples as I see the same thing for each example. I assume you are keeping around the right aligned examples as not to break anything, but can you reorganize the workspace to place the left-aligned example first as the default placement? The way it is now, it feels like this is a secondary variant as opposed to the preferred approach.
There was a problem hiding this comment.
Updates LGTM. Something seems to be wrong with the demo links.
https://patternfly-next-pr-2182.surge.sh/demos/Modal/examples-full?component=Modal%20demo
They all redirect to: https://patternfly-next-pr-2182.surge.sh/demos/Modal/examples-full/ @redallen I wonder if this is a config issue?
| {{#> button button--modifier="pf-m-primary"}} | ||
| Save | ||
| {{/button}} | ||
| {{/modal-box-footer}} |
There was a problem hiding this comment.
Should Save come first, before Cancel?
|
@redallen Actually, none of the demo links are working as expected.. |
D'oh! Updated.
Currently the left-aligned buttons is just a variation, and not the default, so I listed it as we would any other variation from the default. But I see your point. Do we even want to show an example with right aligned buttons, or should they all simply be updated to be left aligned? Or do we want them all to be left aligned, then we show a new example that illustrates the old/legacy alignment where they're right aligned? |
|
@mcarrano @mattnolting updated the examples so they all use the left aligned modifier, and added right aligned demo |
|
Seem to be having a problem with the preview @mcoker . All examples are layering to top of each other.
|
|
@rachael-phillips see @mcarrano's comment ^. That's the workspace problem we discussed yesterday. @mcarrano there's a bug in the preview where all of the examples for a component/demo all show up on one page, so since these demos all occupy the entire viewport width/height, they're overlapped on top of one another. Here are screenshots of the demos: Modal demo
Modal demo - content long enough to scroll
Modal demo - large
Modal demo - legacy footer button alignment (right aligned)
|
|
🎉 This PR is included in version 2.27.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #1599