New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(title): enabled long strings to wrap #2662
Conversation
PatternFly-Next preview: https://patternfly-next-pr-2662.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to fix the problem in most of the cases but if the description has a long URL it will overflow. Maybe using "anywhere"?
@boaz0 can you give me an example? I tried this in both FF and chrome, doesn't overflow. |
Uhh... you'e right! I forgot to mention that if it's inside a <div style={{display: 'flex'}}>
<Title headingLevel="h1" style={{overflowWrap: "break-word"}} size="4xl">
SuperDuperlooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongTitle
</Title> |
@boaz0 ahh good find, that's due to a flex child's default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LPTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lptm!!!
🎉 This PR is included in version 2.58.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #2661