Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icon set #3223

Closed
mcarrano opened this issue Oct 10, 2022 · 3 comments · Fixed by #3263
Closed

Update icon set #3223

mcarrano opened this issue Oct 10, 2022 · 3 comments · Fixed by #3263
Assignees
@evwilkin
Labels
icons
Milestone
2022.14

Comments

@mcarrano
Copy link
Member

We have added a new icon for open-drawer-right. This needs to be added to the set that appears on the Icons page of the website. The updated .zip will is here: https://github.com/patternfly/patternfly-design/tree/master/resources/patternfly-icon-svgs

@evwilkin is there other information that is needed from Design to update this page?
@evwilkin
Copy link
Contributor

evwilkin commented Oct 11, 2022 •
edited

Depends on patternfly/patternfly#5160

@mcarrano we'll need the text to enter into the "Usage/tooltip" column in the icons table

@mcarrano
Copy link
Member Author

For text, how about "Open or close a drawer". @lboehling does that work for you?

@lboehling
Copy link

Yep that works for me @mcarrano !

@evwilkin evwilkin self-assigned this Oct 12, 2022
@mcarrano mcarrano added this to the 2022.14 milestone Oct 14, 2022
@evwilkin evwilkin mentioned this issue Oct 14, 2022
Merged
@evwilkin evwilkin mentioned this issue Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evwilkin evwilkin

Labels
icons
Projects
PatternFly Issues
Archived in project
Milestone
2022.14
Development

Successfully merging a pull request may close this issue.

chore(docs): added new opendrawerrighticon to docs evwilkin/patternfly-org
3 participants
@mcarrano @evwilkin @lboehling