Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): Remove and replace global styles #3996

Merged
merged 2 commits into from May 6, 2024

Conversation

wise-king-sullyman
Copy link
Collaborator

Towards #3945

This PR updates global styles in the quickest way I could so that their removal in core didn't break things and prevent further progress on the style updates or block us from pulling in the latest alphas.

@patternfly-build
Copy link
Contributor

Copy link
Contributor

@jessiehuff jessiehuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any huge issues :)

@srambach
Copy link
Member

srambach commented May 6, 2024

All of these can be follow ups, just documenting -

  • Cookie banner/message needs to have a background.
  • The blue links in the black section at the bottom of the page aren't accessible. Are we keeping the black background I wonder?
  • Get started->Community page - the vertical spacing of sections, headers, etc, is missing
  • I don't see code snippet highlights on react component pages
  • Code snippet highlights run into each other (HTML page) Do we want a little more space or no?
  • Training pages, the cards are messed up https://patternfly-org-pr-3996-site.surge.sh/training/html It looks like instead of a label, we have a tiny card?
  • Utilities - Dark theme dotted outlines on some examples are too light, e.g. https://patternfly-org-pr-3996-site.surge.sh/utility-classes/flex They seem to be good on the layouts.

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐢🍕

@mcoker mcoker merged commit 41fe3eb into patternfly:v6 May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants