Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip #113

Closed
LHinson opened this issue Apr 3, 2018 · 6 comments
Closed

Tooltip #113

LHinson opened this issue Apr 3, 2018 · 6 comments

Comments

@LHinson
Copy link
Member

LHinson commented Apr 3, 2018

The tooltip component requires the following:
CSS to address update visuals and address technical comments seen on current open PR

@LHinson LHinson added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Apr 3, 2018
@mcarrano mcarrano added this to New Feature Request in PatternFly-Next Feature Board Apr 6, 2018
@LHinson LHinson moved this from Backlog to Visual Design in PatternFly 4 Feature Board May 30, 2018
@LHinson LHinson added the visuals label Jun 1, 2018
@LHinson LHinson added this to the 1.0.0-alpha.3 milestone Jun 1, 2018
@LHinson LHinson added alpha 3 and removed alpha 3 labels Jun 1, 2018
@LHinson LHinson added alpha 3 and removed alpha 3 labels Jun 7, 2018
@sjcox-rh
Copy link
Member

Visuals for tooltip.

Two variations shown - on hover and on click.

Please keep in mind to various placements of tooltips when implementing - on right, on left, on top, on bottom.

screen shot 2018-06-12 at 1 59 34 am

Please review!

@christianvogt
Copy link

PopperJS is a very powerful placement library for popovers. It is used to position both the popover box and the arrow. The only stipulation when used for inclusion of arrow placement is that the arrow must be a separate HTML tag and not some pseudo element.

For example:

<div class="pf-c-tooltip">
    <div class="pf-c-tooltip__arrow"></div>
    <div class="pf-c-tooltip__content">Tooltip content here.</div>
</div>

@sjcox-rh
Copy link
Member

Update to visuals:

Separating out tooltip and popover to two separate components.

screen shot 2018-06-12 at 10 15 46 amscreen shot 2018-06-12 at 10 15 58 am

Please keep in mind to various placements of tooltips when implementing - on right, on left, on top, on bottom.

@dgutride dgutride added alpha 3 and removed alpha 3 labels Jun 12, 2018
@LHinson LHinson moved this from Visual Design to CSS/HTML Development in PatternFly 4 Feature Board Jun 19, 2018
@LHinson LHinson added css and removed visuals labels Jun 19, 2018
@trahman73
Copy link

For implementation into Ansible Tower, we feel that 32px padding is very large in relationship to the icon that will trigger the tooltip itself. We also feel the the white background of the tooltips do not provide any contrast against the application even with a drop shadow.

Example of size and background issue:
image

We are proposing a 16px padding tooltip with a dark background (exact color to be suggested by design team) and no drop shadow (shown below). We can offer the choice of dark vs light background as a variable if necessary.

image

Slack Tooltip Example:
image

Github Tooltip Example:
image

@LHinson
Copy link
Member Author

LHinson commented Jul 17, 2018

@trahman73 This issue will be closed out with the current tooltip PR therefore I'm separating this out as its own issue so we can continue to follow up on it. See #474

@LHinson LHinson moved this from CSS/HTML Development to Visual Design in PatternFly 4 Feature Board Jul 19, 2018
@LHinson LHinson added visuals and removed alpha 3 labels Jul 19, 2018
@dgutride dgutride added alpha 4 and removed alpha 4 labels Jul 24, 2018
@LHinson LHinson assigned jlmitch5 and unassigned kybaker Aug 3, 2018
@LHinson LHinson moved this from Visual Design to CSS/HTML Development in PatternFly 4 Feature Board Aug 4, 2018
@LHinson
Copy link
Member Author

LHinson commented Aug 6, 2018

This has been merged so I'm closing this issue.

@LHinson LHinson closed this as completed Aug 6, 2018
@LHinson LHinson moved this from CSS/HTML Development to React Development in PatternFly 4 Feature Board Aug 21, 2018
@LHinson LHinson removed this from React Development in PatternFly 4 Feature Board Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

7 participants