Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of variables causing undefined in IE11 scripts #1869

Closed
dlabaj opened this issue May 30, 2019 · 1 comment
Closed

Order of variables causing undefined in IE11 scripts #1869

dlabaj opened this issue May 30, 2019 · 1 comment
Assignees
Milestone

Comments

@dlabaj
Copy link
Contributor

dlabaj commented May 30, 2019

Order of some of the variables is causing undefined to be created by IE11 script when used as described here:

https://github.com/patternfly/patternfly-next/wiki/IE11-Support

The variables that are being created as undefined are the following:

.pf-c-form__actions {
display: flex;
flex-wrap: wrap;
margin-top: undefined;
margin-right: undefined;
margin-bottom: undefined;
margin-left: undefined;
overflow: hidden; }

.pf-c-login__main-footer-links {
display: flex;
flex-wrap: wrap;
justify-content: center;
padding: 0.5rem 4rem 2rem 4rem;
margin-bottom: undefined; }

.pf-c-wizard__toggle {
position: relative;
z-index: 200;
display: flex;
justify-content: space-between;
width: 100%;
padding: 1.5rem 1rem 1.5rem calc(1rem + undefined + 0.5rem);

.pf-c-wizard__toggle-list {
position: relative;
display: flex;
flex-wrap: wrap;
align-items: baseline;
margin-right: 0.5rem;
margin-bottom: undefined;
list-style: none; }

@dlabaj dlabaj added the bug Something isn't working label May 30, 2019
@dlabaj dlabaj self-assigned this May 30, 2019
@mcoker
Copy link
Contributor

mcoker commented Jun 6, 2019

fixed in #1871

@mcoker mcoker closed this as completed Jun 6, 2019
@rachael-phillips rachael-phillips added this to the Albatross milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants