Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal form label alignment #2167

Closed
mcoker opened this issue Aug 20, 2019 · 2 comments
Closed

Horizontal form label alignment #2167

mcoker opened this issue Aug 20, 2019 · 2 comments
Assignees
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented Aug 20, 2019

The labels in a horizontal form group layout have top-padding to align the label text with a form control element.

Screen Shot 2019-08-20 at 9 36 29 AM

This alignment doesn't work when there is something other than a form control element in the horizontal form group.

Screen Shot 2019-08-20 at 9 35 17 AM

Also if the label text is more than a single line, the alignment looks a little off, though I'd like to confirm with design if this is intended or not.

Screen Shot 2019-08-20 at 9 38 57 AM

@jgiardino
Copy link
Contributor

When adding examples that show a label for a group of checkboxes, we should also make sure that example uses semantic elements and provides labels in a way that is accessible. My last comment in this issue includes a suggestion for this: #953

@christiemolloy christiemolloy self-assigned this Aug 20, 2019
@rachael-phillips rachael-phillips added this to the 2019.07 milestone Aug 21, 2019
@rachael-phillips rachael-phillips modified the milestones: 2019.07, 2019.08 Sep 5, 2019
@redallen
Copy link
Contributor

redallen commented Sep 5, 2019

🎉 This issue has been resolved in version 2.31.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@LHinson LHinson modified the milestones: 2019.08, 2019.07 Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants