Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Layout #34

Closed
andresgalante opened this issue Mar 9, 2018 · 3 comments
Closed

Grid Layout #34

andresgalante opened this issue Mar 9, 2018 · 3 comments
Assignees
Milestone

Comments

@andresgalante
Copy link
Member

I think that we still have an open question about how to replace bootstrap grid system and I’d like to answer that before the meetup.

@andresgalante andresgalante added Feature end user feature that requires design to define this, i.e. changes or augments the user experience. css labels Mar 9, 2018
@andresgalante andresgalante self-assigned this Mar 9, 2018
@andresgalante
Copy link
Member Author

andresgalante commented Mar 15, 2018

Since Matt will create a grid maker mixin, I'll describe the grid system to document the class names

The grid is initiated with the class pf-l-grid and it can have the modifier pf-has-gutters to add or remove gutters:

<div class="pf-l-grid pf-has-gutters">

Each item of the grid is called pf-l-grid__item and it accepts different modifiers depending of the amount of columns and rows we want that item to be in any given breakpoint. It'll also get a modifier to determine in which place the column or row should start with the classes:

  • pf-is-col-2
  • pf-is-row-2
  • pf-start-at-col-3

We have 4 breakpoints, sm, md, lg and xl and we can append that to any of the modfiers, for example pf-is-col-2-sm or pf-is-row-2-md`

Putting everything together we get something like:

<div class="pf-l-grid pf-has-gutters">
  
  <div class="pf-l-grid__item pf-is-col-2-sm pf-is-row-2-sm pf-start-at-col-3-sm">Grid item</div>
  
  <div class="pf-l-grid__item pf-is-col-11">11 col grid item</div>
</div>

there is an example of this here https://codepen.io/andresgalante/pen/dmYRvW?editors=1100

@LHinson LHinson mentioned this issue Mar 20, 2018
@cliffpyles cliffpyles self-assigned this Mar 20, 2018
@LHinson LHinson added this to the dev-meetup-prep milestone Mar 21, 2018
@LHinson LHinson changed the title Create a column layout Create a column layout (Grid) Apr 4, 2018
@LHinson LHinson changed the title Create a column layout (Grid) Grid Layout Apr 4, 2018
@mcarrano mcarrano added this to New Feature Request in PatternFly-Next Feature Board Apr 6, 2018
@andresgalante
Copy link
Member Author

@mattnolting Thanks for helping with this one.

The goal is to take #63, make it work on IE11 and make a solid implementation of responsive classes.

@LHinson LHinson moved this from New Feature Request to Build in PatternFly-Next Feature Board Apr 12, 2018
@dgutride
Copy link
Member

dgutride commented May 4, 2018

Work completed in #193 - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants