Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chip group examples to include __main #3525

Closed
mcoker opened this issue Sep 28, 2020 · 1 comment · Fixed by #3530
Closed

Update chip group examples to include __main #3525

mcoker opened this issue Sep 28, 2020 · 1 comment · Fixed by #3530
Assignees
@mcoker
Milestone
2020.13

Comments

@mcoker
Copy link
Contributor

mcoker commented Sep 28, 2020

Currently __main only wraps a category chip group's labe and list. The __main wrapper should always be present.

We also need to make sure we have examples of the chip group's different variations without __main for reference to test going forward since we will need to support that structure until the next breaking change release.
@mcoker mcoker added this to the 2020.13 milestone Sep 28, 2020
@mcoker mcoker self-assigned this Sep 28, 2020
@mcoker mcoker mentioned this issue Sep 29, 2020
Merged
@redallen
Copy link
Contributor

🎉 This issue has been resolved in version 4.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcoker mcoker

Labels
None yet
Projects
None yet
Milestone
2020.13
Development

Successfully merging a pull request may close this issue.

fix(chip-group): updated all examples to use __main mcoker/patternfly
2 participants
@mcoker @redallen