Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleList selected state moves the UI around #4085

Closed
gdoyle1 opened this issue May 19, 2021 · 8 comments · Fixed by #4099
Closed

SimpleList selected state moves the UI around #4085

gdoyle1 opened this issue May 19, 2021 · 8 comments · Fixed by #4099
Assignees
Milestone

Comments

@gdoyle1
Copy link

gdoyle1 commented May 19, 2021

We are using the SimpleList in OpenShift within our Getting started card, and I've noticed that when you select an item, it makes the text bold which then moves stuff around depending on how long the string is.

Here's a screenshot of the card (don't mind the rest of the cards on that screen :) they are being fixed):
image

cc: @mcarrano

@mcoker
Copy link
Contributor

mcoker commented May 19, 2021

cc @mceledonia

@mceledonia
Copy link

Let's remove the bold style change, @gdoyle1 is this happening on click/active, or are the cards here selectable like a radio/checkbox?

@gdoyle1
Copy link
Author

gdoyle1 commented May 19, 2021

@mceledonia Both on click and when active - most of these links take you to another page so it's just a quick glimpse of the weirdness. But the ones in the middle column remain on the screen as selected since it just brings up the side panel for quick starts

@mcarrano mcarrano added this to 2021.08 - June 23 2021 in PatternFly Feature Roadmap May 19, 2021
@mceledonia
Copy link

Gotcha, let's definitely remove that bold state change then. Was that a part of the original component design? It would be good to know why it is that way in the first place.

@mcarrano
Copy link
Member

I think that @lboehling worked on this originally. Do you see any problem removing the bold styling?

@christianvogt
Copy link

christianvogt commented May 21, 2021

The bold effect happens on focus but not on hover. Noticeable while navigating via keyboard. I'd expect focus and hover states to be the same.

@lboehling
Copy link

The designs did originally have the weight change for selected items to differentiate from the hover state (I think I pulled that treatment from the old light nav/accordion selected states). I agree we should remove the bold styling for selected. We should also consider just using the gray highlight for hover (instead of the current gray highlight + text color change) so that there is a difference between the hover & selected states. @mcarrano @mcoker @mceledonia @gdoyle1

@patternfly-build
Copy link

🎉 This issue has been resolved in version 4.105.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcarrano mcarrano removed this from 2021.08 - June 23 2021 in PatternFly Feature Roadmap Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants