Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text label for X close buttons #525

Closed
jgiardino opened this issue Aug 3, 2018 · 0 comments
Closed

text label for X close buttons #525

jgiardino opened this issue Aug 3, 2018 · 0 comments
Assignees
@andybraren
Milestone
1.0.0-alpha.5

Comments

@jgiardino
Copy link
Contributor

jgiardino commented Aug 3, 2018 •
edited
Loading

The ModalBox and Popover examples should be updated to use "Close" for the text string on the X close button according to #442 (comment)
@jgiardino jgiardino changed the title ModalBox text label for Close button text label for X close buttons Aug 3, 2018
@LHinson LHinson added this to the 1.0.0-alpha.5 milestone Aug 3, 2018
@jgiardino jgiardino mentioned this issue Aug 3, 2018
Merged
This was referenced Aug 10, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andybraren andybraren

Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha.5
Development

No branches or pull requests
3 participants
@LHinson @andybraren @jgiardino