Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - dark theme follow ups #5586

Closed
mcoker opened this issue May 17, 2023 · 1 comment · Fixed by #5668
Closed

Bug - dark theme follow ups #5586

mcoker opened this issue May 17, 2023 · 1 comment · Fixed by #5668
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented May 17, 2023

From #5535

  • Is it possible to swap the brand image in examples where we are looking at the black on white PatternFly brand placeholder? I'm guessing that occurs because we have black text on a transparent background. See Brand and Card examples specifically.
  • I'm noticing that outlined label borders have a weird pixelation in dark theme.
  • I see that the background of the User menu changes when I switch to dark theme. Is that what we expect or want?
  • There's a contrast failure on the read-only code editor.
  • File upload drag over states fail contrast - should the background be a darker gray?
  • Selectable cards
@mcoker mcoker added the bug Something isn't working label May 17, 2023
@mcoker mcoker added this to the 2023.07 milestone May 17, 2023
@mcoker mcoker self-assigned this May 17, 2023
@mcarrano
Copy link
Member

There are also issues with read-only and disabled states for Form control components. See

*Copy to clipboard

  • Forms (text area, text input)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants